Dashboard #1196
Dashboard #1196
Conversation
| @@ -0,0 +1,29 @@ | |||
| {% load umap_tags umap_tags i18n %} | |||
| <table class="maps"> | |||
umap/templates/umap/map_table.html
Outdated
| @@ -0,0 +1,29 @@ | |||
| {% load umap_tags umap_tags i18n %} | |||
| <table class="maps"> | |||
| <tr> | |||
There was a problem hiding this comment.
That tr should be in a thead
umap/templates/umap/map_table.html
Outdated
| <th>{% blocktrans %}Owner{% endblocktrans %}</th> | ||
| <th>{% blocktrans %}Actions{% endblocktrans %}</th> | ||
| </tr> | ||
| {% for map_inst in maps %} |
There was a problem hiding this comment.
That part should be in a <tbody>
There was a problem hiding this comment.
Can you elaborate on why we should add those tags ? I thought that HTML5 thing was to only add needed tags, to KISS :)
There was a problem hiding this comment.
Added <thead> and <tbody>, but not sure why we'd have a <caption>.
Note that all seems optional according to (my understanding of) MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/table :)
I'd say no, given those pages do not a address the same users/needs (we don't need status nor actions for example in the search results) |
Co-authored-by: David Larlet <3556+davidbgk@users.noreply.github.com>
yohanboniface
force-pushed
the
dashboard
branch
2 times, most recently
from
b0c1a6a to
b14733e
Compare
That way is more consistent with ?download and ?edit
|
Merging, so I can put it in today's release, and start working on it in DSRF version. Let's iterate to make it better :) |
|
thank you for this new dashboard interface. I am new to github. Is here that I can suggest an addition in the "status" column, can you also add the detail "Who can see" in addition to "Who can modify" |
|
Makes sense! Something like this ?
|
Very basic version. Must land here so we can theme it in DSFR.
fix #1062
fix #391
cf #1048