Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: duplication of markers #2219

Closed
almet opened this issue Oct 16, 2024 · 0 comments · Fixed by #2388
Closed

Sync: duplication of markers #2219

almet opened this issue Oct 16, 2024 · 0 comments · Fixed by #2388
Labels
bug sync

Comments

@almet
Copy link
Member

almet commented Oct 16, 2024

Posting here a bug report by @yohanboniface

Here are the steps to follow:

  • Tab 1: Create a map, the leave the editing mode.
  • Tab 2: display the map, go in editing mode.
  • Tab 1: Go back in editing mode. Add point A.
  • Tab2: You can see point A.
  • Tab1: Save, exit editing mode.
  • Tab2: Add point B. Save.
  • Tab1: Go back in editing mode.

Two bugs:

  • On Tab1, isDirty is set to True on the map.
  • Bug: When going back to editing mode on Tab1, point B is now present, but point A is duplicated.
@almet almet added the bug label Oct 16, 2024
@almet almet added the sync label Nov 19, 2024
yohanboniface added a commit that referenced this issue Dec 19, 2024
@yohanboniface
chore: add failing test for #2219
d24f059
@yohanboniface yohanboniface mentioned this issue Dec 19, 2024
Merged
@yohanboniface yohanboniface moved this from Todo to In Progress in 🗺️ Road(u)Map Dec 19, 2024
yohanboniface added a commit that referenced this issue Dec 19, 2024
@yohanboniface
Fix duplicated content during sync (#2388)
d4fb92e 
Here are the main fixes:

- mark a synched datalayer as loaded (so the peer does not try to get
data from the server)
- do not mark synched datalayers as dirty
- properly consume the lastKnownHLC, so to get an accurate list of
operations

fix #2219
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🗺️ Road(u)Map Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug sync
Projects
🗺️ Road(u)Map
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix duplicated content during sync umap-project/umap
1 participant
@almet