-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the user to print the current viewed map #1075
base: master
Are you sure you want to change the base?
Conversation
Refs 1904labs/dom-to-image-more#50 too. |
Exciting! Two first comments:
|
I tried at first but it was a bit too complicated for a first time, let's adapt that together.
There is a mechanism to filter out elements but I didn't try it yet!
The two errors are different, we might hit some limitations at some point, the dom-to-image tool is actually re-rendering the whole page to be able to convert it. Also https://github.com/1904labs/dom-to-image-more has probably more bugs fixed but we have to retrieve the fix for iframes (see comments at the top of the copied file). |
Can't we use a print css ? |
We tried https://html2canvas.hertzen.com/ but:
So we do not have background tiles in the preview of the map. |
0e7561b
to
0cba87d
Compare
Refs #88