Use minified versions + sourcemaps of vendor statics #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right! Now that we need the |
| @@ -38,34 +38,19 @@ class UmapManifestStaticFilesStorage(ManifestStaticFilesStorage): | |||
| ), | |||
| ) | |||
|
|
|||
| # https://github.com/django/django/blob/0fcee1676c7f14bb08e2cc662898dee56d9cf207↩ | |||
There was a problem hiding this comment.
This change is unclear to me.
There was a problem hiding this comment.
Previously, we were skipping .map files from the default regexp (because they were missing from the vendors dir) but now that these files are copied it's OK to get back to default and hash these filenames too.
yohanboniface
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to find a way to keep in sync
css.html+js.htmlwithtest/index.html. Maybe generating the page with Django too?