chore: add clean_tilelayer management command #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanboniface
force-pushed
the
clean-tilelayer-command
branch
5 times, most recently
from
d6f1574 to
560ce10
Compare
almet
approved these changes
Mar 11, 2024
| with connection.cursor() as cursor: | ||
| ret = cursor.execute( | ||
| "UPDATE umap_map " | ||
| "SET settings['properties'] = (settings->'properties') - 'tilelayer'" |
| ret = cursor.execute( | ||
| "UPDATE umap_map " | ||
| "SET settings['properties']['tilelayer']['url_template'] = %s " | ||
| "WHERE settings->'properties'->'tilelayer'->'url_template' = %s", |
There was a problem hiding this comment.
Tests seems to be failing because of this line.
There was a problem hiding this comment.
Yep, it passes with my local psql (16), but not with the version 13 of the CI. I've tried many syntaxes, but blindly and without success. I'd need to run a version 13 locally I'd say.
yohanboniface
force-pushed
the
clean-tilelayer-command
branch
from
560ce10 to
87e2c37
Compare
It can be useful to manage the tilelayer registered in the map settings in db.
yohanboniface
force-pushed
the
clean-tilelayer-command
branch
from
87e2c37 to
33c6ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to manage the tilelayer registered in the map settings in db.