feat: integrate facets into browser filters #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how about something like this to differentiate the filter button?
|
|
when filters are closed, feedback should be given if filters are applied. I'm looking at this |
Sounds good! How it looks like when open ? |
|
When open : when filters are closed, feedback if filters are applied : |
almet
reviewed
May 6, 2024
For displaying the badge, we need to know when custom values have been set. Also, this prevent useless facet checks when user has changed one value then changed it back to default.
We need to replace it, so the new value is saved and used elsewhere (eg. in the "UI options" form)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So now browser has three modes:
Layers (everything is collapsed, but user can show/hide/zoom/edit… layers):
Data (filters are collapsed, but layers are expanded):
And filters (everything is expanded):