move formatters and share to a module, and use new GPX library #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanboniface
force-pushed
the
formatters
branch
from
121cc0e to
61a654b
Compare
yohanboniface
force-pushed
the
formatters
branch
4 times, most recently
from
056f524 to
43e1c41
Compare
This mainly allows to dynamically load the third party libraries. In the same process, those libs have changed: - tokml => switch to placemarkio fork, more up to date and available as ESM - togpx => switch to geojson-to-gpx, more up to date and available as ESM (note: this lib does not export polygons, because they do not make sense in GPX world, while the previous was converting them as lines before)
Also add missing .map files. Maybe a proper solution would be to commit the vendors/ and remove manually the comments.
We want to be able to await function there. Specifically, we want to await the data creation when it comes from the `data` url param, so when we also consume the `feature` url param, that feature is already on the map so we can open it
yohanboniface
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly allows to dynamically load the third party libraries needed for converting from/to geojson, so only the needed ones will be loaded.
In the same process, those libs have changed: