-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the table editor including mass actions and filters #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanboniface
force-pushed
the
filter-layer-3
branch
2 times, most recently
from
July 5, 2024 21:54
bfef377
to
89ce9c9
Compare
davidbgk
changed the title
wip: another attemp to massiverly delete features from a condition
Refactor the table editor including mass actions and filters
Jul 8, 2024
yohanboniface
force-pushed
the
filter-layer-3
branch
2 times, most recently
from
July 10, 2024 09:48
273ed73
to
23b4d95
Compare
yohanboniface
force-pushed
the
filter-layer-3
branch
from
July 10, 2024 09:54
23b4d95
to
6b62ec1
Compare
It is only defined when user has write permissions.
so it does not increase the cell width and does not change all the table size. Actually, there is still a small size change as we remove the cell content before adding the input/textarea, but more subtle than before
yohanboniface
force-pushed
the
filter-layer-3
branch
from
July 11, 2024 18:39
6b62ec1
to
4a6b271
Compare
BlurInput adds a "check" button we don't want here.
davidbgk
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very experimental!
cf #1967
Screencast.from.2024-07-04.13-11-26.webm