Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AutocompleteDatalist and use it for conditional rules #1981

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

yohanboniface
Copy link
Member

Extracted from #1967

Copy link
Contributor

@davidbgk davidbgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests for that one

@yohanboniface
Copy link
Member Author

Sadly, I didn't make it: playwright does not seem to allow us to expect what's in the autocomplete. We can click on it, but it will only record the final fill of the input :(

Or do you have another plan in mind ?

@davidbgk
Copy link
Contributor

davidbgk commented Jul 9, 2024

Or do you have another plan in mind ?

Can't we check the content of the datalist in the DOM after filling the input?

@yohanboniface yohanboniface force-pushed the autocomplete-datalist branch from 0beff91 to 7baa70d Compare July 10, 2024 08:11
@yohanboniface yohanboniface merged commit 3fa478a into master Jul 10, 2024
4 checks passed
@yohanboniface yohanboniface deleted the autocomplete-datalist branch July 10, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants