fix: remove position fixed for input and textarea in tableeditor #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanboniface
changed the title
Otherwise when scrolling the table, the input will not appear at the expected position, and may even appear outside of the view when the table is bigger than the viewport. Drawback: the table will resize its columns when the input/textarea is created (as position: sticky is in the flow). So I've also removed the width reset. fix #2071
yohanboniface
force-pushed
the
table-input-position
branch
from
7aecce1 to
d208b19
Compare
davidbgk
approved these changes
Aug 29, 2024
yohanboniface
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise when scrolling the table, the input will not appear at the expected position, and may even appear outside of the view when the table is bigger than the viewport.
Drawback: the table will resize its columns when the input/textarea is created (as block is in the flow). So I've also removed the width reset.
fix #2071