Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a global toolbox in browser #2160

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

yohanboniface
Copy link
Member

fix #2097
cf #1500

image

This is an alternative proposal for #2097:

  • adding the button near the "Filter" toggle was a bit ugly, CSS/HTML talking, because this "Filters" box is a details/summary
  • I thought that other needs could live in the same place: a link to download the filtered/visible data, and a button to show the map data extent

The "toggle all" button works this way:

  • if one or more layers are shown, it will hide those layers
  • otherwise it will show all layers

I've preferred not to change the button icon according to map state, because I didn't find a reliable way to do so, thus I'm afraid to have inconsistency, but I can't try harder if needed.

Related: I'm thinking of adding a "Download" button for each layers, as it's a request that comes quite often.

@Aurelie-Jallut could you have a look ? :)

@Aurelie-Jallut
Copy link
Collaborator

maybe we could contrast the taskbar?
image

@Aurelie-Jallut
Copy link
Collaborator

We could also differentiate the hide all / show all action from the 2 others, which are more related to the layers displayed.

image

@yohanboniface
Copy link
Member Author

Thanks!
Dark background seems reserved for the edit area to me, wdyt ?
Also, I don't really get why separate the toggle button from the others ?

@Aurelie-Jallut
Copy link
Collaborator

Aurelie-Jallut commented Sep 24, 2024

The dark background seems to be reserved for the editing area, doesn't it?

um is that a problem? not sure. it could also be justified by the fact that there are additional editing functions when we edit.
The aim here too is to contrast the different elements with each other to make them easier to read.

Also, I don't really understand why separate the toggle button from the others?
I wanted to try something here : differentiate the 2 buttons linked to the visible layers :

  • zoom for the visible layers
  • Export for the visible layers

with the one that does something different: Hide all layers / Show all layers

@yohanboniface
Copy link
Member Author

Discussed just now: let's add a drop down menu for download options instead of opening another panel and switch context.

@Aurelie-Jallut
Copy link
Collaborator

Test: no grey background, just a line

image

To compare :
image

@yohanboniface
Copy link
Member Author

I prefer the simple line, as you may expect, but… I'll let you decide :)

Just implemented the dropdown:

image

image

Should I make it open above the button (now it's on top of it) ?

@Aurelie-Jallut
Copy link
Collaborator

below (au dessous) :)

@yohanboniface
Copy link
Member Author

Oops, yeah, I meant below :p

Here it is:

image

@yohanboniface yohanboniface merged commit ab703e0 into master Oct 16, 2024
4 checks passed
@yohanboniface yohanboniface deleted the browser-main-toolbox branch October 16, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to isolate a layer
3 participants