fix: use correct icon for layer download advanced action #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
reviewed
Oct 21, 2024
| this._dataUrl(), | ||
| '_blank' | ||
| ) | ||
| const filename = Utils.slugify(this.options.name) |
There was a problem hiding this comment.
Probably miss an extension?
There was a problem hiding this comment.
humm, actually, the downloaded file does have an extension. I guess because we are calling the back office, which set one. So does the download attribute still make sense ?
There was a problem hiding this comment.
No, it's not the backend that sets this extension. Can it be firefox adding it, as the backend sets the content-type to `application/geo+json ?
There was a problem hiding this comment.
What is the content of this.options.name at this point?
There was a problem hiding this comment.
The name of the layer ;)
yohanboniface
added a commit
that referenced
this pull request
Oct 24, 2024
) This was added by the browser I think, but let's be explicit, just in case. cf #2224 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #2221