refactor: Loosen node and version types

umaranis · Dec 4, 2023 · 2f96355 · 2f96355
1 parent c76072a
commit 2f96355
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 23 deletions.
diff --git a/docs/development-notes.md b/docs/development-notes.md
@@ -21,12 +21,12 @@ The tests run in headless mode in the background.
 ### Running locally from CLI
 
 - Start the playground demo
-  - <code>pnpm -C demos/playground dev</code>
+  - `pnpm -C demos/playground dev`
 - Move into the project directory
-  - <code>cd demos/playground</code>
+  - `cd demos/playground`
 - Run tests
-  - All tests (chromium, firefox and safari): <code>pnpm playwright test</code>
-  - Just chromium browser: <code>pnpm test-e2e:chromium</code>
+  - All tests (chromium, firefox and safari): `pnpm playwright test`
+  - Just chromium browser: `pnpm test-e2e:chromium`
 
 The tests run in headless mode in the background.
 

diff --git a/packages/svelte-lexical/src/core/plugins/HorizontalRuleNode.ts b/packages/svelte-lexical/src/core/plugins/HorizontalRuleNode.ts
@@ -11,10 +11,7 @@ import type {
 import {createCommand, DecoratorNode, $applyNodeReplacement} from 'lexical';
 import HorizontalRuleComponent from './HorizontalRuleComponent.svelte';
 
-export type SerializedHorizontalRuleNode = SerializedLexicalNode & {
-  type: 'horizontalrule';
-  version: 1;
-};
+export type SerializedHorizontalRuleNode = SerializedLexicalNode;
 
 export const INSERT_HORIZONTAL_RULE_COMMAND: LexicalCommand<void> =
   createCommand('INSERT_HORIZONTAL_RULE_COMMAND');

diff --git a/packages/svelte-lexical/src/core/plugins/Image/ImageNode.ts b/packages/svelte-lexical/src/core/plugins/Image/ImageNode.ts
@@ -52,8 +52,6 @@ export type SerializedImageNode = Spread<
     showCaption: boolean;
     src: string;
     width?: number;
-    type: 'image';
-    version: 1;
   },
   SerializedLexicalNode
 >;

diff --git a/packages/svelte-lexical/src/core/plugins/KeywordNode.ts b/packages/svelte-lexical/src/core/plugins/KeywordNode.ts
@@ -6,22 +6,11 @@
  *
  */
 
-import type {
-  EditorConfig,
-  LexicalNode,
-  SerializedTextNode,
-  Spread,
-} from 'lexical';
+import type {EditorConfig, LexicalNode, SerializedTextNode} from 'lexical';
 
 import {TextNode} from 'lexical';
 
-export type SerializedKeywordNode = Spread<
-  {
-    type: 'keyword';
-    version: 1;
-  },
-  SerializedTextNode
->;
+export type SerializedKeywordNode = SerializedTextNode;
 
 export class KeywordNode extends TextNode {
   static getType(): string {