Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes from V13 to V14 #16316

Closed
cmwalolo opened this issue May 17, 2024 · 2 comments
Closed

Breaking changes from V13 to V14 #16316

cmwalolo opened this issue May 17, 2024 · 2 comments
Labels
state/needs-reproduction Check if this can be reproduced in the latest released version type/bug

Comments

@cmwalolo
Copy link

cmwalolo commented May 17, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.1.1

Bug summary

I'm trying to migrate 13.1.1 to 14. And I'm stuck as all breaking changes are not reported.

Specifics

For instance one of the breaking functions is :

var url = Url.GetUmbracoApiService<CrolowFormApiController>(_controllers, "InsertComment");

I don't find the correspondency of that function in V14 as some other functions. But I rolled back to V13, I fixed some compilation errors, but I still remained with a bunch of errors.

Steps to reproduce

Just upgrade an umbraco V13 to V14 :-)

Expected result / actual result

I have an application using V13.1.1 that compiles correctly, after upgrade and fixing the breaking changes as stated in the docs, I should be able to reuse my app as is !

Copy link

Hi there @cmwalolo!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Zeegaan
Copy link
Member

Zeegaan commented Jul 8, 2024

Hmm, this should be in v14, it was reintroduced in this PR: #16263
And it's in the sourcecode at least;
image

Is this on the 14.0.0? 🤔
And where are you putting your var url = Url.GetUmbracoApiService<CrolowFormApiController>(_controllers, "InsertComment");,
is this in a view somewhere or ? 😁

Some steps to reproduce this from scratch would be very helpful 🙏

@Zeegaan Zeegaan added state/needs-more-info We don't have enough information to give a good reply state/needs-reproduction Check if this can be reproduced in the latest released version and removed state/needs-more-info We don't have enough information to give a good reply labels Jul 8, 2024
@iOvergaard iOvergaard closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/needs-reproduction Check if this can be reproduced in the latest released version type/bug
Projects
None yet
Development

No branches or pull requests

3 participants