-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V14: Reintroduce umbraco api controller as obsolete #16263
Merged
bergmania
merged 6 commits into
v14/dev
from
v14/feature/reintroduce-umbraco-api-controller
May 13, 2024
Merged
V14: Reintroduce umbraco api controller as obsolete #16263
bergmania
merged 6 commits into
v14/dev
from
v14/feature/reintroduce-umbraco-api-controller
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjac
reviewed
May 10, 2024
kjac
reviewed
May 10, 2024
kjac
reviewed
May 10, 2024
I've added a few comments for you to consider - feels like something was reverted that shouldn't have been. I also added a few more obsoletion messages here and there 😄 The code tests out nicely 💪 this fine controller: using Microsoft.AspNetCore.Mvc;
using Umbraco.Cms.Web.Common.Controllers;
namespace Umbraco.Cms.Web.UI.Custom;
public class MyApiController : UmbracoApiController
{
public IActionResult SayHello() => Ok("Hello!");
} ...is auto-routed as expected: |
|
Good catch 👍 I have obsoleted that constructor too. |
…api-controller' into v14/feature/reintroduce-umbraco-api-controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Reintroduces the UmbracoApiController with a massive obsolete warning.
Test