Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14: Remove mentions of UmbracoApiController #15863

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Mar 11, 2024

Notes

  • Removes UmbracoApiController, UmbracoApiControllerBase & UmbracoApiControllerAttribute classes, and mention of those.
  • This is because this pattern is no longer used at all, and is instead replace with the UmbracoManagementApiControllerBase instead.

How to test

  • The solution should build, and the backoffice should work as is.
  • Create a document type named "Root" with allow as root set to true.
  • Create a template also called "Root"
  • Go to your document type, and be sure to select the template you just created.
  • Create some content with the document type, again ensure the template on the content is correct.
  • Go to the / route and assert you content is rendered 👍

@Migaroez
Copy link
Contributor

Looks good and nothing seems to break.

Is there a linked task to prep the v14 CMS docs for this change? Implementors are very used to simply inheriting from UmbracoApiController and have it auto routed to /umbraco/api and not have to deal with adding it to the reserved paths list.

see https://docs.umbraco.com/umbraco-cms/implementation/controllers#umbraco-api-controllers and https://docs.umbraco.com/umbraco-cms/reference/routing/umbraco-api-controllers

@Zeegaan Zeegaan merged commit 30e2dea into v14/dev Mar 19, 2024
12 of 15 checks passed
@Zeegaan Zeegaan deleted the v14/chore/remove-umbracoAPIcontroller-attribute branch March 19, 2024 13:42
@Zeegaan
Copy link
Member Author

Zeegaan commented Mar 19, 2024

No but good point, I will make sure there is a task covering this change 😁

@Zeegaan Zeegaan added the project/bellissima AKA "the new backoffice" label Mar 19, 2024
bergmania added a commit that referenced this pull request May 10, 2024
bergmania added a commit that referenced this pull request May 13, 2024
* Revert "v14: Remove mentions of UmbracoApiController (#15863)"

This reverts commit 30e2dea.

* Obsolete UmbracoApiController

* Added a few more obsoletion messages

* Removed some of the reintroduced stuff again

* Add obsoletion to FrontEndRoutes controller

---------

Co-authored-by: kjac <kja@umbraco.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants