Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard support for slider #3957

Closed
bjarnef opened this issue Jan 6, 2019 · 7 comments · Fixed by #5651
Closed

Add keyboard support for slider #3957

bjarnef opened this issue Jan 6, 2019 · 7 comments · Fixed by #5651

Comments

@bjarnef
Copy link
Contributor

bjarnef commented Jan 6, 2019

I think it would be great to add keyboard suppport when the handle has focus as in the example.
https://refreshless.com/nouislider/examples/#section-keyboard

There is also an discussion here about keyboard support with two handles:
leongersen/noUiSlider#203

I also found this gist to improve the accessibility of noUiSlider.
https://gist.github.com/felixgirault/3fcb18ee0268b1c3127c

@nul800sebastiaan
Copy link
Member

I've marked this as "Up for grabs" so that you or someone else coming along could create a pull request for it.

@bjarnef
Copy link
Contributor Author

bjarnef commented Jun 12, 2019

@nul800sebastiaan @nielslyngsoe any chance we can update nouislider to version 13.0.0, which now comes with keyboard support build in.

"nouislider": "12.1.0",

leongersen/noUiSlider#724 (comment)

/cc @MMasey

@nul800sebastiaan
Copy link
Member

@bjarnef Sure, go for it!

@bjarnef
Copy link
Contributor Author

bjarnef commented Jun 12, 2019

@nul800sebastiaan of course that would be version 13.1.5 at the time of writing.
https://github.com/leongersen/noUiSlider/releases

From the release notes in seems there are no breaking changes since the current version of noUiSlider used in Umbraco, but mainly enhancement and bug fixes.

@nul800sebastiaan
Copy link
Member

Yeah, all good, v13 does not have any breaking changes listed so should be fine.

@bjarnef
Copy link
Contributor Author

bjarnef commented Jun 12, 2019

I will have a look at it.

@bjarnef
Copy link
Contributor Author

bjarnef commented Jun 12, 2019

PR submitted: #5651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants