v8: Add keyboard support to slider #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bjarnef Thanks for another wonderful contribution. We'll take a look and let you know if we need anything. Looks grand. Em |
…v-v8-nouislider-keyboard-support
|
Oh, now we might want to update to v14.0.0 to include a few more bug fixes, so the keyboard controls fire the |
|
Ah good thinking @bjarnef! |
|
It also seems the developer liked my suggestion to control the stepsize, when using keyboard interaction 👍 |
added 2 commits
June 24, 2019 08:41
…v-v8-nouislider-keyboard-support
|
The noUiSlider has been updated to latest v14 which only include bug fixes, where the the keyboard controls fire the |
|
Works beautifully! Thanks very much @bjarnef 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #3957
Description
This updates noUiSlider used as slider plugin in Umbraco to use version 13.0.0+ which has keyboard support build in.
There are no breaking changes from the current used noUiSlider version only enhancement and bug fixes.
The keyboard support might not be ideal for the slider in image cropper, because the step size in very small (a lot of steps in the range). I have suggested on the noUiSlider issue tracker to be able to set a specific step size when using keyboard in this specific case. leongersen/noUiSlider#992
Furthermore it is only possible the disable keyboard support on noUiSlider (enabled by default), but the
umb-range-sliderdoesn't handle this at the moment. I think it is fine for now the always keep it enabled.