Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V12/feature/enable trust server certificate from installer #14361

Merged
merged 2 commits into from
Jun 12, 2023
Merged

V12/feature/enable trust server certificate from installer #14361

merged 2 commits into from
Jun 12, 2023

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Jun 8, 2023

Notes

  • Add checkbox to SqlServer section in installer
  • Add logic to add TrustServerCertificate to the connection string, if checkbox enabled
  • Refactored building of said connection string.

How to test

  • Create a SQL database (note: this cannot be a LocalDB, but SqlExpress works just fine)
  • Install umbraco using the database (remember to enable the new checkbox to trust the certificate)
  • This should now no longer throw errors 💪

@Zeegaan Zeegaan mentioned this pull request Jun 8, 2023
Closed
nikolajlauridsen
nikolajlauridsen approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nikolajlauridsen nikolajlauridsen merged commit 9a5e1c4 into release/12.0 Jun 12, 2023
@nikolajlauridsen nikolajlauridsen deleted the v12/feature/EnableTrustServerCertificate_From_Installer branch June 12, 2023 08:58
@Zeegaan Zeegaan mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolajlauridsen nikolajlauridsen nikolajlauridsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeegaan @nikolajlauridsen