No longer shows success message if content moving is cancelled

[miguelcrpinto]

Prerequisites

• [x ] I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes issue 13923

Description

• Added AttemptMove method to the ContentService
• Updated ContentController PostMove method to return ValidationProblem whenever the node is not moved

[github-actions]

Hi there @miguelcrpinto, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

Hi @miguelcrpinto!

Thanks for your PR to fix #13923, where a success message shows even if content moving is cancelled.

One of the Core Collaborators team will review this as soon as possible 👍

Best wishes

Emma

[umbrabot]

Hi there @miguelcrpinto!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 15th, 2022, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

📢 We have just published a summary of all the activity throughout this year's Umbraco Hacktoberfest.

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

[lauraneto]

Hi @miguelcrpinto ,

Sorry for the delay!
Unfortunately it's a bit too late to get this to v13, so we have two options:

1. Change the return type of the Move method and target this to v14.
2. Make this non breaking. At the moment your changes are breaking because you have added a new method to an existing public interface.

If you decide to make it non breaking you would have to:

• Have an additional method with a non conventional name (as you already did), but having a default implementation on the interface
• (Optionally) Mark the old method as obsolete (as it doesn't really make sense to keep both methods) and change all of its references to use the new one

Let me know what your thoughts are on this one 😉
Also tagging @nul800sebastiaan for his thoughts.

[nul800sebastiaan]

Good day @miguelcrpinto! Just writing to let you know you have 1 more week to decide if you want a Hacktoberfest t-shirt!
The reward form, featuring the shirt design: https://feedback.umbraco.com/umbraco-hacktoberfest-2023-rewards/

If you don't want anything we'll plant trees instead but I would love for it to be an explicit choice, just choose your username and "No thanks, plant a tree for me please! 🌳" and then you're done! 🙂

[miguelcrpinto]

@lauraneto isn't V14 using different API methods in the backoffice? I can take a look at V14 and see what's being done there and also check if this is still an issue there.

This PR was mean to be a stepping stone to fix issue 13922 but for this issue I'd have to change the API methods return types and the backoffice angular code. The API methods change would also be breaking changes. If 14 uses new API methods, I wonder if it is still worth to fix these.

[lauraneto]

Hi @miguelcrpinto ,

Sorry for the delay!
I tested the initial issue in V14 and good news is that it is fixed there 🙌, by the introduction a breaking change like we had discussed above.
As we cannot apply the same fix for <V13, and V13 is LTS, I think we can go for the (temporary) non breaking route.
I made some slight changes to the code, let me know what you think!

[Matthew-Wise]

@miguelcrpinto thank you for your PR, sorry its taken a while to get this merged