-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content & media url endpoints #15832
Conversation
Added optimizations for documenturlFactory
Duplicated the endpoint for media Cleaned up some code marked async that will never hit a long running operation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few comments before getting to testing 😁
src/Umbraco.Cms.Api.Management/Controllers/Document/DocumentUrlController.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/ViewModels/Document/DocumentUrlInfoResourceSet.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/ViewModels/Media/MediaUrlInfoResourceSet.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Management/Controllers/Media/MediaUrlController.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/Umbraco.Cms.Api.Management/Factories/MediaPresentationFactory.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Migaroez I changed the naming on the resourcesets, please confirm these are the correct names, then we are ready to merge 😁
I am happy with the rename. Merging |
Prerequisites
Description
Testing
/umbraco/amanagement/api/v1/document/urls
/umbraco/amanagement/api/v1/media/urls
Example payloads
Media with image cropper backing field
Media with a generic file backing field
{
"mediaType": {
"id": "4c52d8ab-54e6-40cd-999c-7a5f24903e4d"
},
"values": [
{
"culture": null,
"segment": null,
"alias": "umbracoFile",
"value": "5344f6ae-d305-47fc-955f-3a7778b6c336"
}
],
"variants": [
{
"culture": null,
"segment": null,
"name": "test file"
}
]
}