Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: Rename new projects #15836

Merged
merged 13 commits into from
Mar 12, 2024
Merged

V14: Rename new projects #15836

merged 13 commits into from
Mar 12, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Mar 5, 2024

Notes

Renames all the *.New:* projects to no longer contain new in the name

How to test

  • Make sure you can clone done this branch and run it with no issues

Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪

I just moved the new Umbraco.Web.UI project to the top of the .sln file to be friendly to Visual Studio developerss by setting this project as the default startup project - as you can see we had it similar in v13 .

One thing about the New Backoffice README (which you are removing here), maybe @iOvergaard can jump in:

<Link>UmbracoProject\Views\Partials\blocklist\%(RecursiveDir)%(Filename)%(Extension)</Link>
<PackagePath>UmbracoProject\Views\Partials\blocklist</PackagePath>
</Content>
<Content Include="..\src\Umbraco.Web.UI.New\Views\Partials\grid\**">
<Content Include="..\src\Umbraco.Web.UI\Views\Partials\grid\**">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Umbraco.GridLayout editor has been removed, so we don't need the old partials anymore either. They fail the build if you install it through Umbraco.Templates since they reference assemblies that no longer exist.

@iOvergaard
Copy link
Contributor

@elit0451 We'll make sure to remove the references. As for the README that is removed here, maybe we could update the guide found in ".github/BUILD.md"?

@elit0451
Copy link
Member

Great, thanks 🙌

@Zeegaan, can you add the changes that Jacob suggested 💪

@Zeegaan
Copy link
Member Author

Zeegaan commented Mar 12, 2024

@elit0451 I have added a section about how to get the solution up and running with the git submodule commands, let me know if you're alright with it, or if we need to change it a bit! 💪

.github/BUILD.md Outdated Show resolved Hide resolved
Zeegaan and others added 2 commits March 12, 2024 09:36
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when we have the green lights 🟢

Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Zeegaan Zeegaan merged commit 9c58714 into v14/dev Mar 12, 2024
12 of 15 checks passed
@Zeegaan Zeegaan deleted the v14/chore/rename-new-projects branch March 12, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants