-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V14: Rename new projects #15836
V14: Rename new projects #15836
Conversation
# Conflicts: # src/Umbraco.Web.UI.New.Client
…t project listed in solution file (.sln) since it will be selected as startup one in VS by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💪
I just moved the new Umbraco.Web.UI
project to the top of the .sln file to be friendly to Visual Studio developerss by setting this project as the default startup project - as you can see we had it similar in v13 .
One thing about the New Backoffice README (which you are removing here), maybe @iOvergaard can jump in:
- I can see the usefulness of the
### Getting Started: Backoffice
section until we are working with a submodule. Maybe we can write it down somewhere else? 🤔 - Also, @iOvergaard, can you make sure the
.New
mentions from https://github.com/umbraco/Umbraco.CMS.Backoffice/blob/main/docs/authentication.md are removed as after we merge this PR, the steps will no longer be correct 🙂
templates/Umbraco.Templates.csproj
Outdated
<Link>UmbracoProject\Views\Partials\blocklist\%(RecursiveDir)%(Filename)%(Extension)</Link> | ||
<PackagePath>UmbracoProject\Views\Partials\blocklist</PackagePath> | ||
</Content> | ||
<Content Include="..\src\Umbraco.Web.UI.New\Views\Partials\grid\**"> | ||
<Content Include="..\src\Umbraco.Web.UI\Views\Partials\grid\**"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Umbraco.GridLayout editor has been removed, so we don't need the old partials anymore either. They fail the build if you install it through Umbraco.Templates since they reference assemblies that no longer exist.
@elit0451 We'll make sure to remove the references. As for the README that is removed here, maybe we could update the guide found in ".github/BUILD.md"? |
Great, thanks 🙌 @Zeegaan, can you add the changes that Jacob suggested 💪 |
@elit0451 I have added a section about how to get the solution up and running with the |
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge when we have the green lights 🟢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Notes
Renames all the
*.New:*
projects to no longer contain new in the nameHow to test