Validation messages for blocklists no longer show HTML markup. #15697

[jdearsley]

Prerequisites

• I have added steps to test this contribution in the description below (in the linked issue)

If there's an existing issue for this PR then this fixes (#15697)

Description

Updated valpropertymsg.directive.js to show error messages correctly as HTML rather than escaped text.

Works specifically on Blocklist fields where the minimum / maximum number of elements has not been met.

Create a document type with a block list, with the number of required components as at least 1. Create one, and attempt to save it without adding any components.

The error message should display as HTML rather than "Minimum 1 entries, requires 1 more"

Before:

After:

[github-actions]

Hi there @jdearsley, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[mikecp]

Hi @jdearsley,

Thank you for providing this fix and making sure that validation messages are displayed correctly 👍
And congratulations on your first pull request!!
Someone from the core collaborators team will have a look at it soon.

[mikecp]

Hi again @jdearsley ,

I have just checked your PR, it works perfectly and we can see all warning messages well-formatted again 😁
Let's merge this now !!

This is your first contribution to the Umbraco CMS, congratulations !! 🎉
If you provide us with your account name on the forum (Our), we will gladly add our shiny contributor's badge to you 🏅

Thanks again, and we'll be looking forward to your next contributions 😉

Cheers!

[mikecp]

Oh and I'll also tag it to the new back-office "bellissima" project to make sure they fix it there too 👍

[jdearsley]

Hi Michael, My account name on the forum is the same email address: ***@***.******@***.***> Thanks. Look forward to doing my next PR 😊 J [A blue and black logo Description automatically generated] Joe Dearsley Sitecore CTO ***@***.******@***.***> T +44 (0) 20 7689 8800 www.clerkswell.com<http://www.clerkswell.com/> ClerksWell 309-310, Metal Box Factory, 30 Great Guildford Street, London. SE1 0HS ***@***.*** From: Michael Latouche ***@***.***> Sent: Saturday, March 9, 2024 12:23 AM To: umbraco/Umbraco-CMS ***@***.***> Cc: Joe Dearsley ***@***.***>; Mention ***@***.***> Subject: Re: [umbraco/Umbraco-CMS] Validation messages for blocklists no longer show HTML markup. #15697 (PR #15852) You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> Hi again @jdearsley<https://github.com/jdearsley> , I have just checked your PR, it works perfectly and we can see all warning messages well-formatted again 😁 Let's merge this now !! This is your first contribution to the Umbraco CMS, congratulations !! 🎉 If you provide us with your account name on the forum (Our), we will gladly add our shiny contributor's badge to you 🏅 Thanks again, and we'll be looking forward to your next contributions 😉 Cheers! — Reply to this email directly, view it on GitHub<#15852 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD7A46ZMIIG7EK45HUUYGSDYXJI7PAVCNFSM6AAAAABELHSD52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGU4TIOJZHA>. You are receiving this because you were mentioned.Message ID: ***@***.***> ...................................................................................................................... Internet communications are not secure and therefore ClerksWell Ltd does not accept legal responsibility for the contents of this message. Any views or opinions presented are solely those of the author and do not necessarily represent those of ClerksWell Ltd.