Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14: Move towards get guid #15889

Merged
merged 22 commits into from
Apr 11, 2024
Merged

V14: Move towards get guid #15889

merged 22 commits into from
Apr 11, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Mar 15, 2024

Notes

As most Get(Guid key) methods are not cached, it can hurt performance, thus this PR amends this.
There are 2 possible solutions, and they are by chance both implemented in this respectively for members & users.

  • For members, we now "map" the key to id, the IdKeyMap used Is cached, and thus this conversion from key -> id is fast.
  • For users however, we have refactored it to be the other way around, so getting by ID is not cached (this is only used in obsolete methods/tests), and the GetByKey is now cached.
    This comes with a refactor of the UserRepository that is now a Guid RepositoryBase.
  • Updated UserCacheRefreshers, to also update the GUID in the cache (aka, just remove it)

@kjac kjac self-requested a review March 18, 2024 06:14
@bergmania bergmania merged commit d5809da into v14/dev Apr 11, 2024
14 of 16 checks passed
@bergmania bergmania deleted the v14/feature/move-towards-get-guid branch April 11, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjac kjac kjac left review comments

@bergmania bergmania bergmania approved these changes

Assignees
No one assigned
Labels
category/breaking release/14.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeegaan @bergmania @kjac