Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache a dictionary of dictionaries #15908

Merged
merged 3 commits into from
Aug 17, 2024

Re-delete obsolete

debc72e
Select commit
Loading
Failed to load commit list.
Merged

Cache a dictionary of dictionaries #15908

Re-delete obsolete
debc72e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) succeeded Jun 29, 2024 in 39s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (9.69 -> 9.69)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Primitive Obsession UmbracoHelper.cs

Annotations

Check notice on line 1 in src/Umbraco.Web.Common/UmbracoHelper.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Primitive Obsession 

The ratio of primitive types in function arguments decreases from 54.35% to 52.08%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
View more details on CodeScene Delta Analysis