Convert Tourdata into a more generic concept #15923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeegaan
reviewed
Apr 8, 2024
src/Umbraco.Cms.Api.Management/Controllers/UserData/UserDataControllerBase.cs
Outdated
Show resolved
Hide resolved
* Drop default constraint umbracoCacheInstruction table * Align umbracoContentVersion table * Update indexes on external login table * Align node table * Make relation type index unique * Remove user-group default constraint * Re-order methods * Make webhook url not nullable * Cleanup * Cleanup
# Conflicts: # src/Umbraco.Cms.Api.Management/OpenApi.json
# Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/Tour/GetTourController.cs # src/Umbraco.Cms.Api.Management/Controllers/Tour/SetTourController.cs # src/Umbraco.Cms.Api.Management/OpenApi.json # src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The original goal was to make sure the tour endpoints had no knowledge of what the tour data was and just store it instead of checking the validity. While investigation the code paths and talking to stakeholders for the use cases it became clear a more generic feature would be a better fit instead of trying to push things into a semi happy state.
Userdata is a collection of user bound data identifiable by key or group/identifier. It is not considered an entity but rather a bucket of anything one would like to store against the user without validation/knowledge on the server side. This allows syncing of client related information across multiple hosts. Example: tours and user settings like theme and language.
Cleanup
Breaking changes
Testing