V14: login screen #15932
Merged
V14: login screen #15932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replacement has been built
…-required' into v14/feature/login-screen
…14/feature/login-screen
…14/feature/login-screen
…14/feature/login-screen
…14/feature/login-screen
…tes are no longer a thing
…ogin and show a message instead of the login form
as a fallback language.
leekelleher
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Tested out the login screen, also tested with the 2FA/MFA PR and tested the Forgotten Password feature (with SMTP enabled), all working as expected! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert the V13 login screen to V14 and insert it into the default
login/Index.cshtmlfile so that it loads up by default.Also improved the login screen and fixed some issues that were persistent from V13 and moved localizations and icons from server to client, since they belonged to the old backoffice in V13 and now should be server client-side in V14.
There is one TODO left in the code, that we need to fix after this PR has been merged since it depends on API schemas that haven't been merged into the client yet.