V14: Add cancellation tokens to all endpoints #15984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/DocumentBlueprint/Item/ItemDocumentBlueprintController.cs
Nuklon
reviewed
Apr 5, 2024
src/Umbraco.Cms.Api.Management/Controllers/AuditLog/ByKeyAuditLogController.cs
Show resolved
Hide resolved
elit0451
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Looks good 💪
I just found a few more controllers without the CancellationToken cancellationToken parameter - some that were forgotten (in Item and Tree folders) and some new endpoints (like Document Version/Blueprint ones).
I will push the changes, please have a look at them and we can merge this after 🙂
elit0451
approved these changes
Apr 8, 2024
|
Looks good, and thanks for keeping an eye out for the missed controllers 🎉, turns out that sometimes you can't see the trees for the forest 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
CancellationTokento all endpoints, currently, this isn't used at all, but it will allow us to cancel a request in the future without breaking our API.For the most part, this is pretty run-of-the-mill, the only really interesting part is that I had to alter the
UmbracoTestServerTestBaseslightly to make it work.This is because we use the method parameters to automagically add them as query parameters, however, this is not relevant for cancellation tokens, so I remove those before resolving the query parameters.