-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V14 External login linking + Proposed error handling #16052
Merged
bergmania
merged 5 commits into
v14/dev
from
v14/feature/external-provider-error-handling
Apr 16, 2024
Merged
V14 External login linking + Proposed error handling #16052
bergmania
merged 5 commits into
v14/dev
from
v14/feature/external-provider-error-handling
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migaroez
changed the title
V14/feature/external provider error handling
V14 External login linking + Proposed error handling
Apr 15, 2024
src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs
Fixed
Show fixed
Hide fixed
iOvergaard
reviewed
Apr 15, 2024
bergmania
reviewed
Apr 16, 2024
src/Umbraco.Cms.Api.Management/ViewModels/Security/UnLinkLoginRequestModel.cs
Outdated
Show resolved
Hide resolved
this allows for proper DI for the dependencies
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR introduces some proposed helper methods to uniformly communicate external login errors that come into the backend trough the configured callback methods to a specific frontend path.
Example code
ExampleGithubCode.zip (requires installation of
AspNet.Security.OAuth.GitHub
)This adds all the necessary bits to register github as an external login provider and some bad frontend code to link/unlink.
When starting the linking process from the backend, you will need to open your devtools and click on the CORS blocked link manually to continue, the Frontend team has a task to improve this behaviour
If you use the endpoints, make sure to set the Umbraco authentication cookie as it is needed to figure out what user the linking process should complete on when returning trough the callback.
Updated example registration code