Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons of media types #16290

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Change icons of media types #16290

merged 6 commits into from
Nov 20, 2024

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented May 15, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Suggestion to use audio-lines icon https://lucide.dev/icons/audio-lines for Audio media type instead of waves, which is more like the current icon as mentioned in https://github.com/umbraco/Umbraco.CMS.Backoffice/issues/1457

image

image

I also think it would be great to use a different icon for Vector Graphics (SVG) as it may not necessary be an image, but could be a shape, graphics or even animated SVG and it makes it more clear in tree that these are two different media types.

I will suggest to use this icon https://lucide.dev/icons/scale-3d

image

@iOvergaard I think this would also require to register icon-audio and icon-vector here?
https://github.com/umbraco/Umbraco.CMS.Backoffice/blob/771943bedeefc907e09c85fc242391c2346b5604/src/packages/core/icon-registry/icon-dictionary.json#L2055

However I wonder if this would break the icon if upgrading an project to v14 which has reference to current icon name?

Copy link

github-actions bot commented May 15, 2024

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Nuklon
Copy link
Contributor

Nuklon commented May 16, 2024

@iOvergaard iOvergaard self-assigned this Nov 20, 2024
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a chance to discuss this on the CMS team today. We agree that audio-lines is suitable for the default media audio icon.

As for the default vector graphics, we have decided to go with origami as that signals both a vector graphic as well as a kind of logo that you could potentially use vector graphics for. Indeed, the official logo of SVG is a flower, so we also considered that, but the Umbraco vector graphics type is not limited to SVGs.

I have installed the new icons and updated the defaults so that this affects new installations only.

@iOvergaard iOvergaard merged commit 85f1f81 into umbraco:contrib Nov 20, 2024
7 of 10 checks passed
@bjarnef bjarnef deleted the patch-8 branch November 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants