Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added apostrophe to allowed characters for username. #16406

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

BElluu
Copy link
Contributor

@BElluu BElluu commented May 24, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #16201

Description

Steps:

  1. Log into the backoffice and go to the users section.
  2. Select the "Create user" button.
  3. Complete the fields on the form that appears and enter an email address with an apostrophe (') in it.
  4. Select the "Create user" form submission button.
umbraco-16201.webm

Copy link

github-actions bot commented May 24, 2024

Hi there @BElluu, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@BElluu
Copy link
Contributor Author

BElluu commented May 24, 2024

Checks are failed but I'm sure my changes wont broke it. I cannot rerun them, because I do not have permissions.

@emmagarland
Copy link
Contributor

Hi @BElluu

Thanks for your PR to fix #16201, and allow the apostrophe character.

One of the Core Collaborators team will review this as soon as possible.

I agree that it doesn't seem like your changes have failed the tests, since the others pass.

Best wishes

Emma

@georgebid georgebid self-assigned this Jun 18, 2024
@georgebid
Copy link
Contributor

georgebid commented Aug 2, 2024

Hey @BElluu, thanks again for the PR - I have tested this and can see it working as expected, therefore I will merge this in! 💯

@georgebid georgebid merged commit fc5cd6b into umbraco:contrib Aug 2, 2024
12 of 14 checks passed
@BElluu BElluu deleted the temp/16201 branch August 3, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create user with apostrophe in their username/email
4 participants