Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce INavigationService for in-memory navigation data #16818

Merged
merged 107 commits into from
Sep 4, 2024
Merged

Introduce INavigationService for in-memory navigation data #16818

merged 107 commits into from
Sep 4, 2024

Conversation

elit0451
Copy link
Member

@elit0451 elit0451 commented Jul 25, 2024 •
edited
Loading

Details

  • First step towards making it possible to remove IPublishedContent.Parent, IPublishedContent.Children, IPublishedContent.ChildrenForAllCultures in favour of using in-memory navigation structure (subproject of Lazy Loaded Published Content & Media);
  • Introduces INavigationQueryService and INavigationManagementService for querying and managing navigation-related operations;
    • There are also IRecycleBinNavigationQueryService and IRecycleBinNavigationManagementService equivalents for the trashed items;
  • There are 2 in-memory navigation structures for each content instance (document and media) - one for the main content and one for trashed items;
  • Seeding of the navigation structures (document, media and document recycle bin and media recycle bin) at application startup;
  • Document & Media navigation implementation (query and management);
  • Updates to the navigation structure when the document or media trees update;
  • Tests.

Test

  • All new tests pass.

elit0451 added 29 commits July 15, 2024 09:30
@elit0451
Tests
8200944
@elit0451
Remove props and use local vars
14b02a5
@elit0451
Adding preliminary navigation service and content implementation
e3135e7
@elit0451
Adding preliminary unit tests
dc785c0
@elit0451
Change from async methods
2f77612
@elit0451
Refactor GetParentKey to TryGetParentKey
b435de3
@elit0451
Refactor GetChildrenKeys to TryGetChildrenKeys
45c800a
@elit0451
Refactor GetDescendantsKeys to TryGetDescendantsKeys
d55586c
@elit0451
Refactor GetAncestorsKeys to TryGetAncestorsKeys
d347a00
@elit0451
Refactor GetSiblingsKeys to TryGetSiblingsKeys
1cade45
@elit0451
Refactor TryGetChildrenKeys
2f646c3
@elit0451
Initial integration tests
75d717c
@elit0451
Use ContentEditingService instead of ContentService
9a4565e
@elit0451
Remove INavigationService.Copy implementation and unit tests
1b3d27d
@elit0451
Rename var
fa89e23
@elit0451
Adding clarification
6ffe6d5
@elit0451
Initial ContentNavigationRepository
083d522
@elit0451
Initial NavigationFactory
e949741
@elit0451
Remove filtering from factory
354834a
@elit0451
NavigationRepository and implementation
f99a757
@elit0451
InitializationService responsible for seeding the in-memory structure
e8a2169
@elit0451
Register repository and service
b416a5d
@elit0451
Adding NavigationDto and NavigationNode
ab285ee
@elit0451
Adding INavigationService dependency and Enlist updating navigation s…
8d66ea7 
…tructure actions
@elit0451
Documentation
52f6f75
@elit0451
Adding tests for removing descendants as well
9142148
@elit0451
Changed to ConcurrentDictionary
0cd86c5
@elit0451
Merge remote-tracking branch 'refs/remotes/origin/v14/dev' into v14/f…
c68c130 
…eature/navigation
@elit0451
Remove keys comments for tests
46868fb
@elit0451 elit0451 marked this pull request as ready for review August 26, 2024 12:34
andr317c and others added 5 commits August 29, 2024 08:47
@andr317c
V14 QA added block list editor tests (#16862)
6851113 
* Added tests for blocklistEditor

* Added more tets

* Removed faker

* Added blockTest

* Updates

* Added tests

* Removed dependencies

* Fixes

* Clean up

* Fixed naming

* Cleaned up

* Bumped version

* Added missing semicolons

* Added tags

* Only runs the new tests

* Updates

* Bumped version

* Fixed tests

* Cleaned up

* Updated version

* Fixes, not done

* Fixed tests

* Bumped helpers

* Bumped helpers

* Fixed conflict

* Fixed comment

* Reverted to run smokeTests

* Updated helpers
@bergmania
Merge remote-tracking branch 'origin/v14/dev' into v14/feature/naviga…
0d00fd1 
…tion
@Migaroez @Zeegaan
improve missingProperties data returned for missing propertie values (#…
c277005 
…16910)

Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
@iOvergaard
update backoffice submodule
590b281
@iOvergaard
Merge branch 'v14/dev' of github.com:umbraco/Umbraco-CMS into v14/dev
9321774
bergmania
bergmania reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@bergmania bergmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

tests/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj Show resolved Hide resolved
src/Umbraco.Infrastructure/Persistence/Factories/NavigationFactory.cs Outdated Show resolved Hide resolved
src/Umbraco.Infrastructure/Persistence/Dtos/NavigationDto.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Services/Navigation/NavigationInitializationService.cs Outdated Show resolved Hide resolved
@bergmania bergmania changed the base branch from v14/dev to v15/dev September 3, 2024 10:21
@bergmania bergmania merged commit 5a7d563 into v15/dev Sep 4, 2024
15 of 16 checks passed
@bergmania bergmania deleted the v14/feature/navigation branch September 4, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmania bergmania bergmania left review comments

Assignees
No one assigned
Labels
release/15.0.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elit0451 @bergmania @andr317c @Migaroez @iOvergaard