Fix broken Tours migration for V15 #16912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elit0451
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
#16817 introduced the "User type" as a new property on
User, and ultimately onUserDto. This had the unfortunate side effect of breaking the tours data migration introduced in V14, because it attempts to loadUserDtofrom the DB. This is no longer possible with the new field onUserDto.To fix it, I've retrofitted the migration with
NewUserDto- pretty much the same way the "add GUID to Users" migration works for V14.Testing this PR
Upgrade a DB from V13 to V15. If things do not explode, things work 😆