Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand RedirectUrl.Url storage type to avoid truncation #17038

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

Migaroez
Copy link
Contributor

@Migaroez Migaroez commented Sep 10, 2024

HotFixes #16974

Will have to be rerun in v14 that were upgraded to v14 prior to this PR. The migration has a check to see if the column was migrated before.

Proof it creates the redirects in the database now and length is larger than what it could handle
image

Copy link
Member

@bergmania bergmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Tests out good

@bergmania bergmania merged commit 9a088d3 into release/13.5 Sep 10, 2024
13 checks passed
@bergmania bergmania deleted the v13/fix/redirect-length branch September 10, 2024 16:07
madsoulswe pushed a commit to madsoulswe/Umbraco-CMS that referenced this pull request Sep 18, 2024
* Add migration to expand RedirectUrl.Url to varcharMax

* Simplify Migration

* readded notnull attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants