Block level variants - search indexing #17239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This fixes search indexing for block level variants.
Testing
Setup various permutations of variant, invariant and block level variant content, and test that search indexing works for these content items.
Pay special attention to block level variance in RTEs, as this has proven rather tricky to handle indexing wise.
Breaking change
The signature for all property indexing change quite a bit, to allow an invariant property value to yield multiple index values across different language variants. For example, the
IPropertyIndexValueFactorynow yields anIEnumerable<IndexValue>instead ofIEnumerable<KeyValuePair<string, IEnumerable<object?>>>, where theIndexValuehas language variance built into it.This change is impossible to do in a backwards compatible fashion, because the current implementation with
KeyValuePair<string, IEnumerable<object?>>really does not translate well.