-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Implement sorting for the in-memory navigation structures (document and media) #17280
Merged
bergmania
merged 22 commits into
release/15.0
from
v15/feature/implement-sorting-for-navigation-str
Oct 16, 2024
Merged
V15: Implement sorting for the in-memory navigation structures (document and media) #17280
bergmania
merged 22 commits into
release/15.0
from
v15/feature/implement-sorting-for-navigation-str
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed the failing tests of Member Group due to UI changes * Fixed the failing tests of Member due to UI changes * Fixed the failing tests of User due to UI changes * Fixed failing tests for Dictionary and Document Type * Updated tests due to test helper changes * Bumped version * Updated assert steps due to the response changes * Updated tests due to api helper changes * Updated tests due to UI changes * Fixed tests for delete partial view * Fixed tests * Added more waits * Updated assert steps * Fixed failing tests for Block Grid and Media * Added more waits * Added skip tests * Removed waits time * Updated assertion steps for User * Added todo * Updated tests due to api helper changes * Bumped version * Added skip tests
…n props to keys instead of NavigationNodes
…v15/feature/implement-sorting-for-navigation-str # Conflicts: # src/Umbraco.Web.UI.Client # version.json
…v15/feature/implement-sorting-for-navigation-str # Conflicts: # src/Umbraco.Web.UI.Client
elit0451
changed the title
V15: Implement sorting for the in-memory navigation structure
V15: Implement sorting for the in-memory navigation structures (document and media)
Oct 15, 2024
…mplement-sorting-for-navigation-str # Conflicts: # src/Umbraco.Web.UI.Client
bergmania
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests out great. I love all the new tests 💪
bergmania
deleted the
v15/feature/implement-sorting-for-navigation-str
branch
October 16, 2024 07:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
NavigationNode
model now keeps track of thesortOrder
as well;Parent
andChildren
properties are refactored to referenceGuid
keys instead of the wholeNavigationNode
object - which means we need to resolve theNavigationNode
from the key in all the properties' usages (i.e. ContentNavigationServiceBase).UpdateSortOrder()
to theINavigationManagementService.cs
;Add()
changed its signature to have asortOrder
parameter as well, due to a special case when adding nodes directly to the root (whereparentKey
is null), the sort order must be provided to ensure the item appears in the correct position among other root-level items. We can't calculate the amount of children based on the parent here.Test
ListDescendants.cshtml
;@await Html.PartialAsync("ListDescendants")
to display it, so the template looks like: