Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce a favicon to the templates to allow static file access on first boot #17422

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

bergmania
Copy link
Member

@bergmania bergmania commented Nov 5, 2024

Reintroduce a favicon. I took the default from asp.net core web apps instead of an Umbraco.

Fixes issue introduced by #16840

Test

  • Run the templates and install a starter kit before first boot.
  • Verify static access are available

@Zeegaan Zeegaan merged commit 8e147c2 into release/15.0 Nov 5, 2024
4 of 7 checks passed
@Zeegaan Zeegaan deleted the v15/hotfix/reintroduce-favicon branch November 5, 2024 12:32
@bergmania bergmania changed the title Reintroduce a favicon Reintroduce a favicon to the templates to allow static file access on first boot Nov 5, 2024
nikolajlauridsen pushed a commit that referenced this pull request Nov 6, 2024
* update submodule

* update submodule

* Reintroduce a favicon (#17422)

* Fixes issue where package name was compared to package id, so packages had pending migrations from the management api endpoint, without actually have it.

---------

Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants