Validate client IDs before applying them #17426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
OpenId Connect Client IDs should only be made up of "unreserved characters" - that is, [a-z], [A-Z], [0-9] and [-._~] (see https://en.wikipedia.org/wiki/Percent-encoding).
The back-office client already limits the Client ID input to alphanumerical chars and dash, but of course the API also needs a validation - and that's what this PR adds 😄
Testing this PR
You'll need to use Swagger to test this, due to the above-mentioned restrictions in the back-office.