Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V15/task/cleanup obsolete #17433

Merged
merged 15 commits into from
Nov 7, 2024
Merged

V15/task/cleanup obsolete #17433

merged 15 commits into from
Nov 7, 2024

Conversation

Migaroez
Copy link
Contributor

@Migaroez Migaroez commented Nov 6, 2024

Description

This PR aims to

  • Clean up obsoleted code that is no longer in use
  • Prepare to clean up more obsoleted code by removing our own dependencies on that code by using the alternatives where possible
  • Mark code that is dependent on obsolete code obsolete itself and supplying new code that uses the dependent alternative.

Migaroez and others added 15 commits November 4, 2024 15:11
@Migaroez
Replace obsolete UserGroup Alias consts to key equivalent in tests
72031f2
@Migaroez
Update use of usergroup alias consts to key equivalent in IsSystemgro…
53f57c4 
…up extension method
@Migaroez
Obsolete (internally) unused helper function which purpose doesn't ev…
97407e8 
…en seem true
@Migaroez
Prepped EmbedProviders for proper removal of non async methods and un…
bac856d 
…needed proxy methods
@Migaroez
Remove obsoleted UmbracoPath and updated internal references
8020d30
@Migaroez
Corrected mistake and updated unittets
a0e14c4
@Migaroez
Update usergroup tests that use aliases for "system" groups
d150650
@Migaroez
Replace more uses of globalsettings.UmbracoPath
f1a58f7
@Migaroez
Remove GetDateType by key non async
bfb56e3
@Migaroez
Cleanup some usages of hostingEnvironment.MapPathContentRoot
187388e
@Migaroez
More easy obsoletion cleanup
cee72a3
@Migaroez
Small Typeload cleanup
a4186d2
@Migaroez
More obsolete removal
fac0276
@Migaroez
Deploy obsoletion cleanup
332ed46
@Zeegaan
Remove obsolete methods from OEmbedProviderBase.cs
998bf4f
@Zeegaan Zeegaan merged commit e7eb14d into release/15.0 Nov 7, 2024
12 of 15 checks passed
@Zeegaan Zeegaan deleted the v15/task/cleanup-obsolete branch November 7, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category/breaking release/15.0.0-rc4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Migaroez @Zeegaan