V14: Use decimal in slider property editor #17568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migaroez
approved these changes
Nov 19, 2024
nikolajlauridsen
deleted the
v14/fix/use-decimal-in-slider-property-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the backend part of #17546.
The issue was that the
SliderPropertyEditorassumed that sliders could not be decimal values; however, they can. This can also be seen in theSliderValueConverterand in the models generated by the model builder, which all assume aDecimalvalue.This fixes the backend issues, however, the UI looks quite weird still, when not in range mode the decimals aren't showing, and when in range mode they show but aren't properly formatted showing float imprecision I.E
0.30000000001. Edit: This turned out to be a UUI bug, I've made a fix that has already been merged in UUIFor testing see original issue