Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting files in upload property editor #17587

Conversation

bergmania
Copy link
Member

Description

When you remove an image from a Upload File property editor, it still sends data, with src="". The backend expected a null value. Not backend respects both and delete the existing data when src="" is send

Tests

  • Setup doc type with an Upload file
  • Create a document with an uploaded image
  • Try to remove that image and save. - It should both be deleted from the document and removed from disk

…load property editor, when it did not send null value.
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikolajlauridsen nikolajlauridsen merged commit b402c1f into v15/dev Nov 21, 2024
16 of 17 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v15/bugfix/allow-deleting-files-in-upload-property-editor branch November 21, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants