Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17598 #17599

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fixes #17598 #17599

merged 1 commit into from
Nov 21, 2024

Conversation

PhyxionNL
Copy link
Contributor

Prerequisites

If there's an existing issue for this PR then this fixes: #17598

Description

It's now wrapped correctly:
image

Copy link

github-actions bot commented Nov 20, 2024

Hi there @PhyxionNL, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@leekelleher leekelleher self-requested a review November 20, 2024 19:30
@leekelleher leekelleher self-assigned this Nov 21, 2024
@leekelleher leekelleher merged commit 5518c70 into umbraco:v15/dev Nov 21, 2024
20 checks passed
@leekelleher
Copy link
Member

Super, thank you @PhyxionNL! 🙏

@PhyxionNL PhyxionNL deleted the patch-1 branch November 21, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants