Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "expose" for variant elements with all invariant properties #17621

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Nov 23, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #17521

Description

See the linked issue for a description. Notice that there is a slight error in the issue description, which has been corrected in this comment.

Testing this PR

Variant elements that contain only invariant properties should be exposed correctly - that is, exposed when created in each individual language (they should not behave like invariant elements, because they are indeed variant).

Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 💪

@iOvergaard iOvergaard merged commit 9c76f5c into v15/dev Nov 25, 2024
14 of 17 checks passed
@iOvergaard iOvergaard deleted the v15/fix/17521-expose-fully-invariant-variant-elements branch November 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants