Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15: Notification Hub #17776

Open
wants to merge 29 commits into
base: v15/dev
Choose a base branch
from

Merge branch 'v15/dev' into v15/feature/notification-hub

9da85ad
Select commit
Loading
Failed to load commit list.
Open

V15: Notification Hub #17776

Merge branch 'v15/dev' into v15/feature/notification-hub
9da85ad
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) succeeded Dec 20, 2024 in 57s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.02 (9.90 -> 9.88)

  • Declining Code Health: 4 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Deep, Nested Complexity ServerEventUserManager.cs: RefreshGroupsAsync
  • Code Duplication ServerEventUserManagerTests.cs
  • Large Method UmbracoBuilderExtensions.cs: AddUmbracoManagementApi
  • Complex Method ServerEventUserManager.cs: RefreshGroupsAsync

Annotations

Check warning on line 69 in src/Umbraco.Cms.Api.Management/DependencyInjection/UmbracoBuilderExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ Getting worse: Large Method

AddUmbracoManagementApi increases from 75 to 76 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 83 in src/Umbraco.Cms.Api.Management/ServerEvents/ServerEventUserManager.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method

RefreshGroupsAsync has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 83 in src/Umbraco.Cms.Api.Management/ServerEvents/ServerEventUserManager.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Deep, Nested Complexity

RefreshGroupsAsync has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 33 in tests/Umbraco.Tests.UnitTests/Umbraco.Cms.Api.Management/ServerEvents/ServerEventUserManagerTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Code Duplication

The module contains 2 functions with similar structure: AssignsUserToEventSourceGroup,DoesNotAssignUserToEventSourceGroupWhenUnauthorized. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.