V15: Notification Hub #17776
Open
V15: Notification Hub #17776
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev)
succeeded
Dec 20, 2024 in 57s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.02 (9.90 -> 9.88)
- Declining Code Health: 4 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Deep, Nested Complexity ServerEventUserManager.cs: RefreshGroupsAsync
- Code Duplication ServerEventUserManagerTests.cs
- Large Method UmbracoBuilderExtensions.cs: AddUmbracoManagementApi
- Complex Method ServerEventUserManager.cs: RefreshGroupsAsync
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
❌ Getting worse: Large Method
AddUmbracoManagementApi increases from 75 to 76 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 83 in src/Umbraco.Cms.Api.Management/ServerEvents/ServerEventUserManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
❌ New issue: Complex Method
RefreshGroupsAsync has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 83 in src/Umbraco.Cms.Api.Management/ServerEvents/ServerEventUserManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
❌ New issue: Deep, Nested Complexity
RefreshGroupsAsync has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: AssignsUserToEventSourceGroup,DoesNotAssignUserToEventSourceGroupWhenUnauthorized. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Loading