Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15: Check if language has changed when updating domains #17790

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Dec 12, 2024

Notes

  • Fixes issue found by @nhudinh0309, where you could not change the language on a domain.
  • This happen because we did not change if the language changed, only if the domain name changed, this PR remedies that.

How to test

  • Create another language, so that you have at least 2
  • Create a content type with allow as root set to true
  • Create some content with that type
  • On the document, go to culture and hostnames, and create 2 of the English language, for example /en/test & /en/testtwo
  • Now try switching on of them to another language, this should now work 🙌

Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 💪

@kjac kjac merged commit 64982a1 into release/15.1 Dec 12, 2024
28 checks passed
@kjac kjac deleted the v15/hotfix/create-new-domain-on-update branch December 12, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants