Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Do not re-map schedule modal on error as it leads to broken bindings #17990

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix: Do not re-map schedule modal on error as it leads to broken bindings #17990

merged 1 commit into from
Jan 15, 2025

Conversation

Migaroez
Copy link
Contributor

fixes #17406

@Migaroez Migaroez requested a review from nielslyngsoe January 15, 2025 13:24
AndyButland
AndyButland approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this does fix the issue and I don't see any ill-effects of removing this line. Should perhaps get a review from a FE-er just to see if they can see why this line may have been added in the past and what to look for that could break without it.

@Migaroez
Copy link
Contributor Author

Can confirm this does fix the issue and I don't see any ill-effects of removing this line. Should perhaps get a review from a FE-er just to see if they can see why this line may have been added in the past and what to look for that could break without it.

@nielslyngsoe Helped me figure out it was that line and that it only applies to that dialog so I think we are good 😄

@Migaroez Migaroez merged commit 2a83f57 into release/13.6 Jan 15, 2025
14 checks passed
@Migaroez Migaroez deleted the v13/bugfix/publish-schedule-edgecase branch January 15, 2025 16:35
@Migaroez Migaroez mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyButland AndyButland AndyButland approved these changes

@nielslyngsoe nielslyngsoe Awaiting requested review from nielslyngsoe

Assignees
No one assigned
Labels
area/frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Migaroez @AndyButland