Add validation to prevent update of a user or member to an invalid username (13) #18261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes #17347 and #14823
Description
The core of both reported issues is that whilst we can rely on ASP.NET Identity validating the user name characters, for updates we need to do it ourselves. So I've added that into the validation checks for both users and members.
I also fixed an annoyance with LastPass attempting to fill the user name and leading to accidental updates.
To Test: