Feature: Upgrade Lucide icons and tidy up icon files #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wired up legacy icon paths - Upgraded Lucide npm pkg - Fixed Windows bug in generate script
iOvergaard
approved these changes
Sep 19, 2024
iOvergaard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whilst updating the icons for the Tiptap RTE feature, I'd found that many of the legacy icons weren't wired up correctly and the existing corresponding TypeScript files were being removed by the
npm run generate:iconscommand.I have cleaned up the legacy icon definitions in the
icon-dictionary.jsonfile, (relocating them to theumbracosection, as the SVGs are locally on disk).Also, upgraded Lucide (to latest
lucide-static@0.441.0), as a few icons were missing/renamed; and I fixed a bug in the devops icon generator script (related to Windows file paths).Most of the changes in this PR are the Lucide version number bump
Types of changes