Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Tiptap drag and drop upload #2318

Merged
merged 34 commits into from
Sep 20, 2024
Merged

Feature: Tiptap drag and drop upload #2318

merged 34 commits into from
Sep 20, 2024

Conversation

iOvergaard
Copy link
Collaborator

@iOvergaard iOvergaard commented Sep 19, 2024 •
edited
Loading

How to test

  1. Drag images and save
  2. Check that the HTML is replaced by the actual media item
  3. (Optional) Check that you can "edit" the item through the mediapicker plugin when that is set up

@iOvergaard
chore: optimise file manager class
6fa94c2
@iOvergaard
fix: give UmbImage an extension name
fb11b67
@iOvergaard
feat: adds a media upload extension supporting drag and drop
dc77644
@iOvergaard
chore: add mock handlers for "temporary-file"
d3710f3
@iOvergaard
chore: add delay to file handler
2fa644a
@iOvergaard
feat: add localization and correct name of data-tmpimg
4779c15
@iOvergaard
chore: remove debug data
199daa1
@iOvergaard
feat: make the datatype configuration available to extensions
ce99b09
@iOvergaard
feat: calculate image size for files added to the editor so that we c…
8359211 
…an set `width` and `height`
@iOvergaard
feat: update the contents if we ever get a new value
fc47667
@iOvergaard
feat: add a hasChanged checker to the value to check specifically if …
a85f2f7 
…the markup has changed
@iOvergaard
feat: only update value when changed
1349f9d
@iOvergaard
fix: assume any to avoid linting error
7f16ff5
@iOvergaard
fix: move options back to UmbImage element to ensure everything is av…
99c5cb1 
…ailable when the editor loads
@iOvergaard
store value in another variable
3ac8db5
@iOvergaard
feat: override value property to interact with tiptap
4ea6983
@iOvergaard
feat: introduce a backing field for markup to be able to add markup f…
64390a1 
…rom the beginning
@iOvergaard
feat: use #markup backing field
1233db4
@iOvergaard
feat: only calculate html on updates
9642beb
@iOvergaard
chore: remove clog
b37c2c2
@iOvergaard
fix: allow configuration to be undefined
a8c1787
@iOvergaard
fix: use local editor
d542912
@iOvergaard
chore: sort imports
5da5e0f
@iOvergaard
chore: restore comments
0c5f54b
@iOvergaard
Merge remote-tracking branch 'origin/v15/feature/tiptap' into v15/fea…
4347fb2 
…ture/tiptap-media-upload
@iOvergaard
fix: types after merge
28d7cbf
@iOvergaard
Merge remote-tracking branch 'origin/v15/feature/tiptap' into v15/fea…
860eaf0 
…ture/tiptap-media-upload
@iOvergaard
Merge remote-tracking branch 'origin/v15/feature/tiptap' into v15/fea…
c2d6bd7 
…ture/tiptap-media-upload
@iOvergaard
feat: move imageSize function to util file
f979669
@iOvergaard
feat: move imageSize function to general utils
8fe308e
@iOvergaard iOvergaard marked this pull request as ready for review September 20, 2024 09:58
JesmoDev
JesmoDev approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@JesmoDev JesmoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iOvergaard iOvergaard merged commit 218e960 into v15/feature/tiptap Sep 20, 2024
2 checks passed
@iOvergaard iOvergaard deleted the v15/feature/tiptap-media-upload branch September 20, 2024 12:12
@iOvergaard iOvergaard added the ignore-for-release Pull requests that will not be included in the automated release notes. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesmoDev JesmoDev JesmoDev approved these changes

@leekelleher leekelleher Awaiting requested review from leekelleher

Assignees
No one assigned
Labels
ignore-for-release Pull requests that will not be included in the automated release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iOvergaard @JesmoDev