Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Tiptap toolbar extension configuration #2459

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Bugfix: Tiptap toolbar extension configuration #2459

merged 8 commits into from
Oct 14, 2024

Conversation

leekelleher
Copy link
Member

Description

Bugfix and enhancement on the Tiptap toolbar configuration.

  • Monitors Extensions configuration, updates Toolbar options accordingly (highlighted/disabled UI)
    • Disabling an extension will not remove an item from the toolbar, it will mark it as disabled, (for the user to take further action, in case it was a mistake).
    • Includes edge-case for Blocks configuration, if none are configured, the corresponding extension is disabled
  • Adds a hard-coded option for "Rich Text Essentials", this effectively does nothing, but indicated that there are "core" capabilities available, (e.g. bold, italic, et al).
  • Reworks the Toolbar row/groups UI, (making use of the UUI Button Inline Create component)
  • Adds accessibility features
    • Keyboard navigation / tabbing over the extension/toolbar items
    • Focusing on an available toolbar item, pressing Enter or Space will add to the last row/group area
    • With the reverse for selected toolbar items, pressing Enter or Space will remove an item
    • Adds filtering support to the Available Items panel
  • Localization keys for various new labels have been added

Provides fixes for...

To note, sorting of rows/groups/items has not been implemented yet, (development is in progress).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How to test?

Create a new Tiptap RTE data-type, (or use an existing one), try enabling/disabling features; try adding Blocks configuration (then removing them); try keyboard navigation (tabbing); try adding toolbar rows/groups/items, then removing them, etc.

Screenshots

Screenshot 2024-10-14 131900

@leekelleher
Reordered Tiptap extension manifests
6fa2089 
Removed the weighing and put into order of perceived usefulness.
@leekelleher
Reworked Tiptap Extensions configuration
0572b5a 
Refactored UI to be a grouped checkbox lists,
improves on intend and accessibility.
@leekelleher
Adds "Rich Text Essentials" as a hard-coded core option
cb74612 
This is to indicate that the basic formatting,
e.g. bold, italic, etc are enabled by default.
@leekelleher
Relocated UmbTiptapToolbarValue
290551f
@leekelleher
Updated tiptapToolbarExtension manifest with forExtensions data
e81d42f
@leekelleher
Updated Tiptap data-type config labels/descriptions
943d7fe
@leekelleher
Tiptap toolbar designer reworking
7dbe84c 
Observes the enabled extensions,
updates available items accordingly.

Adds a context API and label localizations.
@leekelleher
Tiptap extensions field
2e38ed2 
observes the Block configuration,
updates UI accordingly, to enable/disable the Block extension.
@iOvergaard iOvergaard merged commit 722c508 into release/15.0 Oct 14, 2024
9 checks passed
@iOvergaard iOvergaard deleted the v15/feature/tiptap-toolbar-designer branch October 14, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
release/15.0.0-rc2 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leekelleher @iOvergaard